feat: Centralize configuration in one place. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cullylarson
requested review from
cball,
kgajera,
alexanderson1993,
mthomps4 and
dennis-campos
kgajera
requested changes
Apr 10, 2023
2 tasks
kgajera
approved these changes
Apr 10, 2023
| }), | ||
| database: z.object({ | ||
| url: z.string(), | ||
| shouldMigrate: coerceBoolean, |
There was a problem hiding this comment.
Do we want to default shouldMigrate to true or process.env.NODE_ENV === 'production'? I think this might trip people up.
There was a problem hiding this comment.
It's set explicitly by the SHOULD_MIGRATE environment variable. Which, I realized I forgot to add to the .env files.
|
CI is failing because of some issues with how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
process.envreferences intoconfig.ts.ts-node-dev. Doesn't seem to be needed, creates some weird situations where processes don't exist (e.g.buildProd).buildProdscript.bisonappis different from prettier config inpackages/create-bison-app/template. So if you save a file while editingbisonappand then create a bison app from it, it may have lint errors. Resolved this by copying the prettier config frompackages/create-bison-app/templateinto the root folder.Checklist